fmonjalet commented on code in PR #16152:
URL: https://github.com/apache/datafusion/pull/16152#discussion_r2102849012
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -529,7 +529,12 @@ impl GroupedHashAggregateStream {
})
.collect();
- let name = format!("GroupedHashAggregateStream[{partition}]");
+ let agg_fn_names = aggregate_exprs
+ .iter()
+ .map(|expr| expr.name().to_string())
Review Comment:
nit: have you tried out `human_display()`? It shows `count(1)` instead of
`count(Int64(1))` in this case, wondering if it's better overall for error
messages or not.
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -529,7 +529,12 @@ impl GroupedHashAggregateStream {
})
.collect();
- let name = format!("GroupedHashAggregateStream[{partition}]");
+ let agg_fn_names = aggregate_exprs
+ .iter()
+ .map(|expr| expr.name().to_string())
+ .collect::<Vec<String>>()
Review Comment:
minor: I think you should not need to allocate a `String` explicitly, you
can join on slices
```suggestion
.map(|expr| expr.name())
.collect::<Vec<_>>()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
