timsaucer opened a new pull request, #16170:
URL: https://github.com/apache/datafusion/pull/16170

   ## Which issue does this PR close?
    
   - Closes #15797
   
   ## Rationale for this change
   
   This is an alternative to https://github.com/apache/datafusion/pull/16053
   
   In this version, we change the enum variant of `Literal` in both logical and 
physical expressions to contain the optional metadata. This is a deeper change 
than #16053 but it does make an easier to follow data flow path. Rather than 
relying on complex checking on the schema during simplification and creation of 
the physical plans, it adds the schema to the logical expression.
   
   ## What changes are included in this PR?
   
   - Add optional metadata to literal variant of logical expression
   - Add optional metadata to literal variant of physical expression
   - Update optimizer to combine metadata on aliases
   
   ## Are these changes tested?
   
   Tested with unit tests and add additional unit test that specifically checks 
for metadata on the input and output of scalar values.
   
   ## Are there any user-facing changes?
   
   The biggest change is that users who check literal values will need to 
update their enum variants to take and pass the additional metadata field.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to