andygrove commented on PR #1782:
URL:
https://github.com/apache/datafusion-comet/pull/1782#issuecomment-2905395842
> This PR reads it from the `SQLConf`, serializes it to the native side, and
stashes it in `SparkParquetOptions`. I don't see what happens with it after
that. Presumably we could then use this info in the `SchemaAdapter` but I don't
see that logic anywhere. I think it's just a dead-end config like
`is_adapting_schema` right now.
We do have code that uses this config:
```rust
if self.parquet_options.case_sensitive {
b.name() == field.name()
} else {
b.name().to_lowercase() ==
field.name().to_lowercase()
}
```
The newly added test was previously failing for `native_datafusion` (but not
for `native_iceberg_compat` for some reason).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
