logan-keede commented on PR #16076: URL: https://github.com/apache/datafusion/pull/16076#issuecomment-2905880785
Hi @ajita-asthana, are you still working on this issue? consider implementing a benchmark like [this](https://github.com/apache/datafusion/blob/main/datafusion/functions/benches/chr.rs) first(in a separate PR) to measure the performance of current `chr` function against the one you have implemented. You should also mark this as a draft PR till then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org