alamb commented on code in PR #16167: URL: https://github.com/apache/datafusion/pull/16167#discussion_r2106168938
########## datafusion/functions-nested/src/length.rs: ########## @@ -128,26 +148,20 @@ pub fn array_length_inner(args: &[ArrayRef]) -> Result<ArrayRef> { match &args[0].data_type() { List(_) => general_array_length::<i32>(args), LargeList(_) => general_array_length::<i64>(args), + DataType::ListView(_) => general_array_length::<i32>(args), Review Comment: I think it is a good idea to remove `ListView` from this PR and add it back when support has improved in general -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org