rluvaton commented on code in PR #15022:
URL: https://github.com/apache/datafusion/pull/15022#discussion_r2106174038
##########
datafusion/functions-aggregate-common/src/aggregate/groups_accumulator.rs:
##########
@@ -299,6 +424,17 @@ impl GroupsAccumulatorAdapter {
}
impl GroupsAccumulator for GroupsAccumulatorAdapter {
+ fn register_metadata(&mut self, metadata: GroupsAccumulatorMetadata) ->
Result<()> {
Review Comment:
The reason I did not add it to `update_batch` is:
1. it gives the feeling that the value can change between calls while it's
not
2. requires breaking change which I wanted to avoid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
