mbutrovich commented on code in PR #1799:
URL: https://github.com/apache/datafusion-comet/pull/1799#discussion_r2112261140
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -118,7 +119,17 @@ case class CometScanRule(session: SparkSession) extends
Rule[SparkPlan] {
return withInfos(scanExec, fallbackReasons.toSet)
}
- val typeChecker = new CometScanTypeChecker(scanImpl)
+ val possibleDefaultValues =
getExistenceDefaultValues(scanExec.requiredSchema)
+ if (possibleDefaultValues.exists(d => {
+ d != null && (d.isInstanceOf[ArrayBasedMapData] || d
+ .isInstanceOf[GenericInternalRow] ||
d.isInstanceOf[GenericArrayData])
Review Comment:
They're already Java-native types at this point for Spark's internal
interface. We can't check SQL types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
