alamb commented on code in PR #15871:
URL: https://github.com/apache/datafusion/pull/15871#discussion_r2112273596
##########
datafusion/functions-aggregate/src/count.rs:
##########
@@ -764,4 +774,49 @@ mod tests {
assert_eq!(accumulator.evaluate()?, ScalarValue::Int64(Some(0)));
Ok(())
}
+
+ #[test]
+ fn test_nested_dictionary() -> Result<()> {
Review Comment:
I recommend adding something to the aggregate fuzzer:
https://github.com/apache/datafusion/blob/7d3c7d8c6a9f4883d4e513d9657d8e48f439bc3b/datafusion/core/tests/fuzz_cases/aggregate_fuzz.rs#L4
If you add coverage for adding Dictionary arrays and verify `COUNT(DISTINCT
..)` that would generate some good results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
