berkaysynnada commented on code in PR #16166:
URL: https://github.com/apache/datafusion/pull/16166#discussion_r2113294832
##########
datafusion/datasource/src/file_format.rs:
##########
@@ -120,7 +121,26 @@ pub trait FileFormatFactory: Sync + Send + GetExt +
fmt::Debug {
&self,
state: &dyn Session,
format_options: &HashMap<String, String>,
- ) -> Result<Arc<dyn FileFormat>>;
+ ) -> Result<Arc<dyn FileFormat>> {
+ let options = match self.options() {
Review Comment:
They should implement `default_from_output_format` and `options`. This
change is not directly related to the actual changes of the PR, but all
create() methods show a similar pattern, so I remember we thought like why not
avoid duplication
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
