jonathanc-n commented on code in PR #16210:
URL: https://github.com/apache/datafusion/pull/16210#discussion_r2114981517
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -810,6 +871,123 @@ fn build_join_indices(
}
}
+// Find matching indices based on join `on` predicates
Review Comment:
Not sure if this is the most efficient way? I tried to add comments wherever
possible to make the review process easier, and the logic is straight forward
(should be simple to review 😄 ).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
