alamb opened a new pull request, #16214: URL: https://github.com/apache/datafusion/pull/16214
## Which issue does this PR close? - Follow on for https://github.com/apache/datafusion/pull/16148 ## Rationale for this change During the review of https://github.com/apache/datafusion/pull/16148 from @kosiew 🙏 @adriangb and I had some suggestions to simplify the API and make upgrading easier. However, it wasn't clear how they would look so I tried them out and it turns out they worked well ## What changes are included in this PR? This PR simplifies the API: 1. Change `FileForma::with_schema_adapter_factory` to return an Result 1. Provides a default implementation for with_schema_adapter_factory (which avoids having to change `FileFormat` implementations) 2. Removes the `impl_schema_adapter_methods` macro 3. Consolidate the newly added standalone integration tests (as individual tests results in longer build times, as each test ends up as its own binary) ## Are these changes tested? Yes by CI <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
