alamb commented on PR #16222: URL: https://github.com/apache/datafusion/pull/16222#issuecomment-2927088025
> The clickbench only has several cases with real regression > 20%, and i believe those cases can be improved by combined with adaptive, i think we are at good state. I agree -- thank you @zhuqi-lucas I have a few other optimization ideas on https://github.com/apache/datafusion/pull/16208#issuecomment-2927076431 that will help this case too. It would also be super helpful to profile / review the queries where the performance slows down , like Q14 and Q21 and see if those are the ones where the adaptive filtering would help ``` │ QQuery 14 │ 856.70ms │ 1029.41ms │ 1.20x slower │ │ QQuery 22 │ 2199.07ms │ 2431.34ms │ 1.11x slower │ ``` Q14: ```sql SELECT "SearchEngineID", "SearchPhrase", COUNT(*) AS c FROM hits WHERE "SearchPhrase" <> '' GROUP BY "SearchEngineID", "SearchPhrase" ORDER BY c DESC LIMIT 10; ``` Q21: ```sql SELECT "SearchPhrase", MIN("URL"), COUNT(*) AS c FROM hits WHERE "URL" LIKE '%google%' AND "SearchPhrase" <> '' GROUP BY "SearchPhrase" ORDER BY c DESC LIMIT 10; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
