alamb commented on code in PR #16221:
URL: https://github.com/apache/datafusion/pull/16221#discussion_r2119245089
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1626,12 +1626,19 @@ pub fn build_join_schema(
join_type,
left.fields().len(),
);
- let metadata = left
+
+ let (schema1, schema2) = match join_type {
Review Comment:
👍 makes sense to me
It looks like there is a very similar piece of code here:
https://github.com/apache/datafusion/blob/6844e56504d41b69608a1ae46f8b0563e1c8b473/datafusion/physical-plan/src/joins/utils.rs#L317-L323
Maybe it also needs updating 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
