andygrove commented on code in PR #1825:
URL: https://github.com/apache/datafusion-comet/pull/1825#discussion_r2119347211
##########
native/proto/src/proto/expr.proto:
##########
@@ -72,18 +72,17 @@ message Expr {
NormalizeNaNAndZero normalize_nan_and_zero = 45;
TruncDate truncDate = 46;
TruncTimestamp truncTimestamp = 47;
- UnaryExpr bitwiseNot = 48;
- Abs abs = 49;
- Subquery subquery = 50;
- UnboundReference unbound = 51;
- BloomFilterMightContain bloom_filter_might_contain = 52;
- CreateNamedStruct create_named_struct = 53;
- GetStructField get_struct_field = 54;
- ToJson to_json = 55;
- ListExtract list_extract = 56;
- GetArrayStructFields get_array_struct_fields = 57;
- ArrayInsert array_insert = 58;
- MathExpr integral_divide = 59;
+ Abs abs = 48;
+ Subquery subquery = 49;
+ UnboundReference unbound = 50;
+ BloomFilterMightContain bloom_filter_might_contain = 51;
+ CreateNamedStruct create_named_struct = 52;
+ GetStructField get_struct_field = 53;
+ ToJson to_json = 54;
+ ListExtract list_extract = 55;
+ GetArrayStructFields get_array_struct_fields = 56;
+ ArrayInsert array_insert = 57;
+ MathExpr integral_divide = 58;
Review Comment:
It is generally best not to change the id of the existing fields to help
reduce merge conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
