0ax1 opened a new pull request, #16230: URL: https://github.com/apache/datafusion/pull/16230
For queries 2, 3, 10, 18 and 21 the TPC-H spec defines a row count limit. ``` 2.1.2.9 Queries 2, 3, 10, 18 and 21 require that a given number of rows are to be returned (e.g., “Return the first 10 selected rows”). If N is the number of rows to be returned, the query must return exactly the first N rows unless fewer than N rows qualify, in which case all rows must be returned. There are three permissible ways of satisfying this requirement. A test sponsor must select any one of them and use it consistently for all the queries that require that a specified number of rows be returned. ``` https://www.tpc.org/tpc_documents_current_versions/pdf/tpc-h_v2.17.1.pdf ## Which issue does this PR close? - Closes #16229. ## Rationale for this change Returned row counts should match the TPC-H spec. ## What changes are included in this PR? `limit` clause was added to TPC-H queries, 2, 3, 10, 18, 21. ## Are these changes tested? I re-ran all of the affected queries locally to double-check their row counts. ## Are there any user-facing changes? Users will now see the correct row counts when running TPC-H benchmarks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
