suibianwanwank commented on code in PR #16234:
URL: https://github.com/apache/datafusion/pull/16234#discussion_r2122871124
##########
datafusion/physical-expr/src/window/aggregate.rs:
##########
@@ -85,6 +88,18 @@ impl PlainAggregateWindowExpr {
);
}
}
+
+ fn is_window_constant(order_by: &LexOrdering, window_frame: &WindowFrame)
-> bool {
Review Comment:
> This is nice, I think we should have a comment to explain why
That makes sense, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
