gabotechs commented on code in PR #16195:
URL: https://github.com/apache/datafusion/pull/16195#discussion_r2123429852
##########
datafusion/physical-plan/src/metrics/value.rs:
##########
@@ -516,6 +596,21 @@ impl MetricValue {
(Self::EndTimestamp(timestamp),
Self::EndTimestamp(other_timestamp)) => {
timestamp.update_to_max(other_timestamp);
}
+ (
+ Self::Custom { value, name },
+ Self::Custom {
+ value: other_value,
+ name: other_name,
+ },
+ ) => {
+ if name != other_name {
+ panic!(
+ "Unsupported metric aggregation between {name} and
{other_name}"
+ )
+ }
+
Review Comment:
Other metrics do not seem to be applying this restriction, for being
consistent with other metrics, maybe we can relax this restriction here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
