pepijnve commented on code in PR #16262:
URL: https://github.com/apache/datafusion/pull/16262#discussion_r2131600952
##########
benchmarks/compare.py:
##########
@@ -148,10 +174,23 @@ def compare(
)
continue
- total_baseline_time += baseline_result.execution_time
- total_comparison_time += comparison_result.execution_time
+ if detailed:
+ baseline_value = baseline_result.mean_execution_time
+ comparison_value = comparison_result.mean_execution_time
+ baseline_text = f"{baseline_result.min_execution_time:.2f} /
{baseline_value:.2f} ±{baseline_result.stddev_execution_time:.2f} /
{baseline_result.max_execution_time:.2f} ms"
Review Comment:
I've moved the formatting logic to a method to remove the duplication and
updated the failure handling code path to respect the detail flag as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
