LiaCastaneda commented on code in PR #16346:
URL: https://github.com/apache/datafusion/pull/16346#discussion_r2135765414


##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -3525,6 +3525,12 @@ impl ScalarValue {
             }
         }
     }
+
+    /// Compacts ([ScalarValue::compact]) the current [ScalarValue] and 
returns it.
+    pub fn compacted(mut self) -> Self {

Review Comment:
   would there be ay benefit in adding #[inline] this since its a small 
function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to