gabotechs commented on code in PR #16348: URL: https://github.com/apache/datafusion/pull/16348#discussion_r2136979543
########## datafusion/sqllogictest/test_files/array.slt: ########## @@ -3070,6 +3070,30 @@ select array_concat([]); ---- [] +# test with NULL array +query ? +select array_concat(NULL::integer[]); +---- +NULL + Review Comment: How about adding a couple of cases that test the other different list types? ```sql # test with NULL LargeList query ? select array_concat(arrow_cast(NULL::string[], 'LargeList(Utf8)')); ---- NULL # test with NULL FixedSizeList query ? select array_concat(arrow_cast(NULL::string[], 'FixedSizeList(2, Utf8)')); ---- NULL ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
