alamb commented on code in PR #16320: URL: https://github.com/apache/datafusion/pull/16320#discussion_r2139153886
########## datafusion/expr/src/expr.rs: ########## @@ -601,7 +625,7 @@ pub struct Alias { pub expr: Box<Expr>, pub relation: Option<TableReference>, pub name: String, - pub metadata: Option<std::collections::HashMap<String, String>>, + pub metadata: Option<FieldMetadata>, Review Comment: This line is the point of the PR is to use the `FieldMetadata` struct introduced in this PR everywhere: - https://github.com/apache/datafusion/pull/16317 The rest of the changes in this PR are consequences of this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org