pepijnve commented on PR #16322: URL: https://github.com/apache/datafusion/pull/16322#issuecomment-2966838912
I don't think it's necessary TBH. I applied this patch (which I think is what @berkaysynnada meant) and the test then fails in the way it's intended to. ``` Index: datafusion/physical-plan/src/sorts/merge.rs IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/datafusion/physical-plan/src/sorts/merge.rs b/datafusion/physical-plan/src/sorts/merge.rs --- a/datafusion/physical-plan/src/sorts/merge.rs (revision 31c570e3ee7fa830753b2bbab3ec1a635ef16a30) +++ b/datafusion/physical-plan/src/sorts/merge.rs (date 1749736195516) @@ -227,7 +227,8 @@ // The polled stream is pending which means we're already set up to // be woken when necessary // Try the next stream - idx += 1; + // idx += 1; + return Poll::Pending; } _ => { // The polled stream is ready ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org