UBarney commented on PR #16390: URL: https://github.com/apache/datafusion/pull/16390#issuecomment-2969058654
> however @UBarney was able to point out that a on clause already included in the join filter 🤦. I mean that non-equal condition(eg `<=>`) in `on` will be included in the join filter. (sorry for misundering) https://github.com/apache/datafusion/pull/16210#discussion_r2144133973 I think we can support `null_equals_null` in nlj by merging `on` condition into `filter` and reusing existing filter logical. For instance, if `null_equals_null` is enabled, a condition like `filter: t1.a < t2.a, on: t1.c = t2.c` would be transformed into a single filter: filter: `t1.a < t2.a and t1.c <=> t2.c`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
