comphead commented on PR #16409:
URL: https://github.com/apache/datafusion/pull/16409#issuecomment-2973512315

   Got it @shehabgamin 
   
   I'm seeing a lot of  `slt` tests like
   ```
   #S
   
   
    #E
    #query
    #L
   ```
   
   which not very explanatory. 
   For testing `spark` integration it would probably be interesting something 
we did in `Comet` 
https://github.com/apache/datafusion-comet/blob/6bf80b107cc1574cb7f259719d0aa203e387efc4/spark/src/test/scala/org/apache/comet/CometExpressionCoverageSuite.scala#L48
   
   So the test takes recent samples from internal Spark examples and run it, 
comparing the actual(Spark provided) and expected values


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to