andygrove commented on PR #1866:
URL:
https://github.com/apache/datafusion-comet/pull/1866#issuecomment-2976849328
@rluvaton Here is a test that fails in main and passes with your changes in
this PR. Could you add this to `CometAggregateSuite` as part of this PR?
```scala
test("first/last with ignore null") {
val data = Range(0, 8192).flatMap(n => Seq((n, 1), (n, 2))).toDF("a",
"b")
withTempDir { dir =>
val filename = s"${dir.getAbsolutePath}/first_last_ignore_null.parquet"
data.write.parquet(filename)
withSQLConf(CometConf.COMET_BATCH_SIZE.key -> "100") {
spark.read.parquet(filename).createOrReplaceTempView("t1")
for (expr <- Seq("first", "last")) {
// deterministic query that should return one non-null value per
group
val df = spark.sql(s"SELECT a, $expr(IF(b==1,null,b)) IGNORE NULLS
FROM t1 GROUP BY a ORDER BY a")
checkSparkAnswerAndOperator(df)
}
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
