alamb commented on code in PR #15261:
URL: https://github.com/apache/datafusion/pull/15261#discussion_r2150964083
##########
datafusion/datasource/src/schema_adapter.rs:
##########
@@ -98,6 +100,46 @@ pub trait SchemaMapper: Debug + Send + Sync {
fn map_batch(&self, batch: RecordBatch) ->
datafusion_common::Result<RecordBatch>;
}
+pub trait MissingColumnGeneratorFactory: Debug + Send + Sync {
Review Comment:
I haven't had a chance to review this entire PR yet, but I am feeling a
little strange that these traits are not used by `SchemaMapper` but instead are
used by `DefaultSchemaMapper`
I wonder what is the usecase for these extra two traits, compared to say
adding a method on `SchemaMapper`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
