alamb commented on PR #15958:
URL: https://github.com/apache/datafusion/pull/15958#issuecomment-2983591412

   > > @irenjj - I wonder if you would be willing to help pick this PR back up 
now that we have merged a PR with a bunch of tests from @shehabgamin here:
   > > 
   > > * [chore: generate basic spark function testsĀ 
#16409](https://github.com/apache/datafusion/pull/16409)
   > > 
   > > We are hoping to generate some example PRs to use when starting to fill 
out the rest of the functions and I was thinking this one might be a good one
   > 
   > Sure! I need some time to figure out why new added ceil/floor only works 
with one argument(it seems datafusion has an original implementation for 
ceil/floor), i'll do this work next week(little busy this week) -- Sorry for 
dragging out this PR for so long @shehabgamin @andygrove
   
   Thanks @irenjj  -- no worries about the timing. I know you are busy and are 
also on the leading edge of these spark functions  (so the process of 
implementation is a bit rough). Thank you for helping us figure it out 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to