UBarney commented on code in PR #16443:
URL: https://github.com/apache/datafusion/pull/16443#discussion_r2156308803
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -510,8 +511,6 @@ impl ExecutionPlan for NestedLoopJoinExec {
})?;
let batch_size = context.session_config().batch_size();
- let enforce_batch_size_in_joins =
- context.session_config().enforce_batch_size_in_joins();
Review Comment:
We can remove the `enforce_batch_size_in_joins` configuration for nested
loop join since
1. The new implementation in this PR achieves both improved performance and
lower memory usage. This surpasses the previous state where
`enforce_batch_size_in_joins` was used to toggle between better performance
(false) and lower memory usage (true).
https://github.com/apache/datafusion/blob/e6df27c3ba49b32fef0689c87cb787d2f6948939/datafusion/common/src/config.rs#L404-L408
2. Verification confirms that results remain correct without this
configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
