Re: [PR] Perf: Optimize in memory sort [datafusion]

Thu, 19 Jun 2025 09:02:28 -0700 


alamb commented on PR #15380:
URL: https://github.com/apache/datafusion/pull/15380#issuecomment-2988564894

   ๐Ÿค–: Benchmark completed
   
   <details><summary>Details</summary>
   <p>
   
   
   ```
   Comparing HEAD and concat_batches_for_sort
   --------------------
   Benchmark sort_tpch.json
   --------------------
   โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Query        โ”ƒ       HEAD โ”ƒ concat_batches_for_sort โ”ƒ    Change โ”ƒ
   โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ Q1           โ”‚  334.77 ms โ”‚               334.65 ms โ”‚ no change โ”‚
   โ”‚ Q2           โ”‚  306.13 ms โ”‚               292.37 ms โ”‚ no change โ”‚
   โ”‚ Q3           โ”‚ 1202.95 ms โ”‚              1171.68 ms โ”‚ no change โ”‚
   โ”‚ Q4           โ”‚  418.47 ms โ”‚               421.97 ms โ”‚ no change โ”‚
   โ”‚ Q5           โ”‚  418.14 ms โ”‚               417.66 ms โ”‚ no change โ”‚
   โ”‚ Q6           โ”‚  454.33 ms โ”‚               441.03 ms โ”‚ no change โ”‚
   โ”‚ Q7           โ”‚  900.60 ms โ”‚               898.49 ms โ”‚ no change โ”‚
   โ”‚ Q8           โ”‚  774.41 ms โ”‚               769.11 ms โ”‚ no change โ”‚
   โ”‚ Q9           โ”‚  820.96 ms โ”‚               811.73 ms โ”‚ no change โ”‚
   โ”‚ Q10          โ”‚ 1204.89 ms โ”‚              1200.38 ms โ”‚ no change โ”‚
   โ”‚ Q11          โ”‚  731.77 ms โ”‚               742.05 ms โ”‚ no change โ”‚
   โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Benchmark Summary                      โ”ƒ           โ”ƒ
   โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ Total Time (HEAD)                      โ”‚ 7567.43ms โ”‚
   โ”‚ Total Time (concat_batches_for_sort)   โ”‚ 7501.12ms โ”‚
   โ”‚ Average Time (HEAD)                    โ”‚  687.95ms โ”‚
   โ”‚ Average Time (concat_batches_for_sort) โ”‚  681.92ms โ”‚
   โ”‚ Queries Faster                         โ”‚         0 โ”‚
   โ”‚ Queries Slower                         โ”‚         0 โ”‚
   โ”‚ Queries with No Change                 โ”‚        11 โ”‚
   โ”‚ Queries with Failure                   โ”‚         0 โ”‚
   โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   ```
   
   
   </p>
   </details>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to