2010YOUY01 commented on PR #16463: URL: https://github.com/apache/datafusion/pull/16463#issuecomment-2990142949
Thank you! This is great. I got some minor suggestions: 1. The issue explained the motivation of the change clearly, I recommend to add the same rationale to the code comment to make the code more understandable. 2. We can unify `gc_record_batch()` and this existing function https://github.com/apache/datafusion/blob/3c4e39ac0cf83bd8ead45722a5873bac731b53f1/datafusion/physical-plan/src/sorts/sort.rs#L469 I'm also happy to take this on as a follow-up task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
