alamb commented on code in PR #16469:
URL: https://github.com/apache/datafusion/pull/16469#discussion_r2160016165
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -580,6 +581,24 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
// cooperate with yielding.
None
}
+
+ /// Returns a new execution plan that uses the provided work table, if
supported.
Review Comment:
As this comment notes, this method is quite specific to `WorkTableExec`
I wonder if it might be a good idea to make a slightly more general API for
updating state
Maybe something like
```rust
fn with_updated_state(&self, state: Arc<dyn Any>) -> Option<Arc<dyn
ExecutionPlan>>
```
This would allow any arbitrary state to be updated and would make it eaiser
for wrapper nodes like that in Datafusion tracing to pass through state without
having to know anything about what is in it 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
