AdamGS commented on PR #16491: URL: https://github.com/apache/datafusion/pull/16491#issuecomment-2993626439
LGTM. IDK if there's a precedence to formatting the error case as an empty string elsewhere in Datafusion. It seems like `format_option!` uses `"NULL"` as sort of a display sentinel value, maybe values like this need their own placeholder? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
