alamb commented on PR #16080: URL: https://github.com/apache/datafusion/pull/16080#issuecomment-2994126025
> Yep that's what I meant. Personally I think either default is justifiable, but before this PR there were 2 different defaults depending on your usage. But having a single default is inevitably going to have some regressions for some people. I thought that having the default in the session config (false) i.e. not collect statistics by default would have less bad of a worst case scenario, but feedback on the other thread seemed to indicate otherwise and I'm happy to accept that - we don't use the default either way. Yes -- exactly. > Based on my (admittedly new and shallow) experience, it feels like DataFusion is geared more towards the first use case rather than the second so it feels like the “obvious” default is to collect statistics. @davisp this is what @AdamGS did (changed the default to true -- always collect statistics) in - https://github.com/apache/datafusion/issues/16158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org