alamb commented on code in PR #15776:
URL: https://github.com/apache/datafusion/pull/15776#discussion_r2160311322


##########
datafusion/core/src/physical_planner.rs:
##########
@@ -1598,8 +1600,16 @@ pub fn create_aggregate_expr_with_name_and_maybe_filter(
                 physical_name(e)?
             };
 
-            let physical_args =
+            // Create base physical expressions (without coercion)

Review Comment:
   I think typically coercsion is applied ealier in the planning proesses, not 
after physiscal expressions have been crated
   
   Did you consider applying the coercsion along with the other coercion ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to