Vedin commented on code in PR #1894: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1894#discussion_r2161623234
########## src/parser/mod.rs: ########## @@ -15018,6 +15018,9 @@ impl<'a> Parser<'a> { /// Parse a FETCH clause pub fn parse_fetch(&mut self) -> Result<Fetch, ParserError> { + if dialect_of!(self is SnowflakeDialect) { + return self.parse_snowflake_fetch(); + } Review Comment: I made `parse_fetch` more permissive. As I understood, the parser will allow wire syntax and skip some errors in other dialects. Is it a common way to fix such issues? Just want to know it for the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org