eliaperantoni commented on code in PR #1891: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1891#discussion_r2166676894
########## tests/sqlparser_common.rs: ########## @@ -7964,7 +7964,7 @@ fn parse_create_view_with_columns() { let sql = "CREATE VIEW v (has, cols) AS SELECT 1, 2"; // TODO: why does this fail for ClickHouseDialect? (#1449) // match all_dialects().verified_stmt(sql) { - match all_dialects_except(|d| d.is::<ClickHouseDialect>()).verified_stmt(sql) { + match all_dialects_where(|d| !d.is::<ClickHouseDialect>()).verified_stmt(sql) { Review Comment: Ah whoops! Not really, it's only a relic of a previous commit which I partially reverted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org