gabotechs commented on PR #16519: URL: https://github.com/apache/datafusion/pull/16519#issuecomment-3004986202
EDIT: I'm seeing that there's cases where the `merge_batch` method is used for something other than merging states: https://github.com/apache/datafusion/blob/9278233e9fe34f7712370f2fa583ba94663a0678/datafusion/physical-plan/src/aggregates/no_grouping.rs#L232-L239 Which means that probably we do want compaction to happen also in the `merge_batch` function. I think this is good to go then 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
