parthchandra commented on PR #1915: URL: https://github.com/apache/datafusion-comet/pull/1915#issuecomment-3006004050
@leung-ming do you think the dragonbox module you've implemented can be contributed back to [dragonbox](https://github.com/dtolnay/dragonbox)? I would feel more confident if someone with a better fundamental understanding of the algorithm reviewed your work. @andygrove the dragonbox crate has a Apache2-LLVM/Boost license. I think but am not sure, there should be no issue of compatibility with the Apache license? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
