chenkovsky commented on code in PR #16538:
URL: https://github.com/apache/datafusion/pull/16538#discussion_r2167849726
##########
datafusion/sql/src/expr/function.rs:
##########
@@ -375,6 +375,10 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
return plan_err!("WITHIN GROUP clause is required when
calling ordered set aggregate function({})", fm.name());
}
+ if !fm.is_ordered_set_aggregate() && !within_group.is_empty() {
+ return plan_err!("WITHIN GROUP clause is not permitted for
non-ordered set aggregate function({})", fm.name());
Review Comment:
I think order-sensitive means order is necessary. but for array_agg, order
is optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
