jkosh44 commented on code in PR #16558:
URL: https://github.com/apache/datafusion/pull/16558#discussion_r2173511981
##########
datafusion/substrait/src/logical_plan/producer/types.rs:
##########
@@ -360,6 +372,11 @@ mod tests {
round_trip_type(DataType::Timestamp(TimeUnit::Nanosecond, tz))?;
}
+ round_trip_type(DataType::Time32(TimeUnit::Second))?;
+ round_trip_type(DataType::Time32(TimeUnit::Millisecond))?;
+ round_trip_type(DataType::Time64(TimeUnit::Microsecond))?;
+ round_trip_type(DataType::Time64(TimeUnit::Nanosecond))?;
+ round_trip_type(DataType::Date64)?;
Review Comment:
Oops sorry I forced pushed to re-run CI and of course reverted this fix.
Another wake up call to start using `--force-with-lease`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
