iffyio commented on code in PR #1908:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1908#discussion_r2173612089
##########
src/parser/mod.rs:
##########
@@ -8477,7 +8477,14 @@ impl<'a> Parser<'a> {
pub fn parse_alter_table_operation(&mut self) ->
Result<AlterTableOperation, ParserError> {
let operation = if self.parse_keyword(Keyword::ADD) {
if let Some(constraint) = self.parse_optional_table_constraint()? {
- AlterTableOperation::AddConstraint(constraint)
+ let mut not_valid = false;
Review Comment:
For both this flag and the new validate constraint clause, can we can skip
the dialect methods and have the parser always accept the syntax if it shows up
in a statement? since the syntax doesn't look like it conflicts with other
dialects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
