irenjj commented on code in PR #16611:
URL: https://github.com/apache/datafusion/pull/16611#discussion_r2173665868
##########
datafusion/optimizer/src/decorrelate_dependent_join.rs:
##########
@@ -165,30 +174,52 @@ impl DependentJoinDecorrelator {
}
}
fn new(
- correlated_columns: &Vec<(usize, Column, DataType)>,
- parent_correlated_columns: &IndexMap<usize, Vec<CorrelatedColumnInfo>>,
+ node: &DependentJoin,
+ // correlated_columns: &Vec<(usize, Column, DataType)>,
+ parent_correlated_columns: &mut IndexMap<usize,
Vec<CorrelatedColumnInfo>>,
Review Comment:
actually the same depth can cause to create different DelimGet, like in paper
<img width="446" alt="Screenshot 2025-06-29 at 17 08 51"
src="https://github.com/user-attachments/assets/81ff106e-65f0-4517-93fb-b981ae240f56";
/>
node9 has both outerRef T2.b and T1.a at the same level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
