alamb commented on PR #16599: URL: https://github.com/apache/datafusion/pull/16599#issuecomment-3018906835
> I agree, not so sure either :) though I was also thinking about other areas where we might do casting in filter expression and therefore limit the pushdown usefulness. Needs some examples though to show this is happening. I think we already have a bunch of tests for this (no casts on the column) for string view, for example https://github.com/apache/datafusion/blob/ebf49b4fe585820caaad3b8c04529633190f48be/datafusion/sqllogictest/test_files/string/string_view.slt#L212-L219 @adriangb is also thinking about / working on a more general predicate optimziation in - https://github.com/apache/datafusion/pull/16530 They are on my list of things to review this week (the code changes are coming fast and furious) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
