ViggoC commented on code in PR #16615:
URL: https://github.com/apache/datafusion/pull/16615#discussion_r2178075914
##########
datafusion/expr/src/expr.rs:
##########
@@ -1175,26 +1175,26 @@ impl Exists {
/// User Defined Aggregate Function
///
-/// See [`udaf::AggregateUDF`] for more information.
+/// See [`crate::udaf::AggregateUDF`] for more information.
#[derive(Clone, PartialEq, Eq, Hash, Debug)]
pub struct AggregateUDF {
/// The function
- pub fun: Arc<udaf::AggregateUDF>,
+ pub fun: Arc<crate::AggregateUDF>,
/// List of expressions to feed to the functions as arguments
pub args: Vec<Expr>,
/// Optional filter
pub filter: Option<Box<Expr>>,
/// Optional ORDER BY applied prior to aggregating
- pub order_by: Option<Vec<Expr>>,
+ pub order_by: Vec<Sort>,
Review Comment:
This was a mistake during the batch replacement process, but since this
struct has never been used in the project, it did not cause any exceptions.
I'll change it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
