rishvin opened a new pull request, #1971:
URL: https://github.com/apache/datafusion-comet/pull/1971
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #532
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Spark in ANSI mode can throw division by zero exception for remainder,
however, the remainder implementation in Comet is not ANSI compliant and rather
than throwing division by zero, returns NULL. This PR introduces remainder that
is compliant with Spark behavior, both in ANSI and non-ANSI mode.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Adds a new physical expression `ModuloExpr`. This expression supports both
ANSI and non-ANSI mode (via `fail_on_error` flag). In ANSI mode, it translates
the Arrow's division by zero error to Spark compliant error message.
- Removes the call to `nullIfWhenPrimitive`, when serializing the remainder
exception, and implements equivalent functionality in `ModuloExpr`. This method
set null values for RHS record batches that have zero values in them. This is
required for non-ANSI mode, otherwise Arrow's remainder implementation will
throw divide by zero exception.
- Adds rust and scala tests cases to verify remainder behaviour both in ANSI
and non-ANSI mode.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Added rust and scala tests to verify the behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
