adriangb commented on code in PR #16646:
URL: https://github.com/apache/datafusion/pull/16646#discussion_r2178616357
##########
datafusion/datasource-parquet/src/source.rs:
##########
@@ -343,9 +343,7 @@ impl ParquetSource {
}
/// If true, the predicate will be used during the parquet scan.
- /// Defaults to false
- ///
- /// [`Expr`]: datafusion_expr::Expr
+ /// Defaults to false.
Review Comment:
Well this bit is just a comment 😛
But this produced wrong results because we'd return `Supported(filter)` up
to the parents -> `FilterExec` removed from the plan but
`ParquetOpener.pushdown_filters = false` -> pruning did not actually happen
during the scan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
