kosiew commented on code in PR #1145: URL: https://github.com/apache/datafusion-python/pull/1145#discussion_r2179607660
########## examples/datafusion-ffi-example/Cargo.lock: ########## @@ -748,9 +750,8 @@ dependencies = [ [[package]] name = "datafusion" -version = "47.0.0" -source = "registry+https://github.com/rust-lang/crates.io-index"; -checksum = "ffe060b978f74ab446be722adb8a274e052e005bf6dfd171caadc3abaad10080" +version = "48.0.0" +source = "git+https://github.com/apache/datafusion?rev=33a32d4382bee7e3c705d0f55d05c24a115a2f98#33a32d4382bee7e3c705d0f55d05c24a115a2f98"; Review Comment: I am curious why this lock file entry contains a revision commit point. ########## examples/datafusion-ffi-example/Cargo.lock: ########## @@ -748,9 +750,8 @@ dependencies = [ [[package]] name = "datafusion" -version = "47.0.0" -source = "registry+https://github.com/rust-lang/crates.io-index"; -checksum = "ffe060b978f74ab446be722adb8a274e052e005bf6dfd171caadc3abaad10080" +version = "48.0.0" +source = "git+https://github.com/apache/datafusion?rev=33a32d4382bee7e3c705d0f55d05c24a115a2f98#33a32d4382bee7e3c705d0f55d05c24a115a2f98"; Review Comment: Maybe regenerate the lock file to avoid curious questions like mine 😄 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
