feral-dot-io opened a new pull request, #1919: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1919
I have need to get the location info of an `Expr::TypedString` but this currently returns a `Value` rather than a `ValueWithSpan`. I saw that the parser already has access to this information. So this is a small PR changes Expr::TypedString to use a ValueWithSpan. I have also updated the test cases and docs. One issue with this PR is that the I've used `Span::empty()` in the test cases and it still passed. Looking at a PG test more closely the span was being filled with non-zero locations. Checking another PG test it seemed that span tests were skipped by using pattern matching; I didn't want to do this because I wanted to avoid accidentally change the tests. Or it might be fine as it is. Let me know how you'd like to deal with this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
