andygrove commented on code in PR #1980: URL: https://github.com/apache/datafusion-comet/pull/1980#discussion_r2180560974
########## docs/source/contributor-guide/spark-sql-tests.md: ########## @@ -138,8 +138,12 @@ wiggle --replace ./sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.sc The diff file can be generated using the `git diff` command. It may be necessary to set the `core.abbrev` configuration setting to use 11 digits hashes for consistency with existing diff files. +Note that there is an `IgnoreComet.scala` that is not part of the Spark codebase, and therefore needs to be added +using `git add` before generating the diff. + ```shell git config core.abbrev 11; +git add sql/core/src/test/scala/org/apache/spark/sql/IgnoreComet.scala Review Comment: This is new -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
