alamb commented on code in PR #16645:
URL: https://github.com/apache/datafusion/pull/16645#discussion_r2180842064
##########
datafusion/physical-plan/src/windows/bounded_window_agg_exec.rs:
##########
@@ -262,9 +262,9 @@ impl DisplayAs for BoundedWindowAggExec {
.iter()
.map(|e| {
format!(
- "{}: {:?}, frame: {:?}",
+ "{}: {}, frame: {}",
e.name().to_owned(),
- e.field(),
+ e.field().unwrap(),
Review Comment:
Can we change this to avoid the unwrap?
Something like
```rust
let field match e.field() => {
Ok(f) => f.to_string(),
Err(e) => format!("{:?}", e.field())
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
